Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont require github.com token #52

Closed
sta-szek opened this issue Nov 10, 2021 · 5 comments
Closed

Dont require github.com token #52

sta-szek opened this issue Nov 10, 2021 · 5 comments
Labels
backlog Planned for future

Comments

@sta-szek
Copy link

sta-szek commented Nov 10, 2021

hello, thanks for this action! 馃
it saved some hours of my work 馃嵒

however, i have small request.

would it be possible to change the implementation, not to use github.com token for the github api?

i mean this piece of code:

async function getLatestHelmVersionFor(type: string): Promise<string> {
    const token = core.getInput('token', { 'required': true });

the problem is that we run the action hundreds of thousands of times every day (we have bilions of microservices, each will run it at least 3 times on single PR! and bunch of active developers that are creating PRs every second)

all that, in conjunction, is creating massive attak on github API, which requires github.com token -> as a result, the token is API Rate limited :/

can we somehow use latest as version, to fetch latest, but do not query github api?

as a result we have blocked pipelines, which is defniately not the way to go.
also, we can consider changing version to some fixed version, but then we need to update the version manually, which is also not the way to go :(

@sta-szek sta-szek added the need-to-triage Requires investigation label Nov 10, 2021
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Nov 24, 2021
@qpetraroia
Copy link
Collaborator

Hi @sta-szek,

We currently have an engineer who is refactoring this action. We will continue to update you with our progress as we move forward.

@qpetraroia qpetraroia removed need-to-triage Requires investigation idle Inactive for 14 days labels Jan 3, 2022
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jan 17, 2022
@qpetraroia qpetraroia added backlog Planned for future and removed idle Inactive for 14 days labels Jan 24, 2022
@qpetraroia
Copy link
Collaborator

The fix should be out soon

@OliverMKing
Copy link
Collaborator

Fixed with #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Planned for future
Projects
None yet
Development

No branches or pull requests

3 participants