Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONiC Management Framework Release 1.0 #18

Merged
merged 886 commits into from
Dec 23, 2019

Conversation

PrabhuSreenivasan
Copy link
Collaborator

@PrabhuSreenivasan PrabhuSreenivasan commented Sep 18, 2019

SONiC Management Framework Release 1.0

  • Combined development from Broadcom and Dell
  • Adds support for CLI, REST and GNMI interfaces
  • YANG based data modeling
  • Schema and syntax validation for Redis DB data using CVL
  • written in GO programming language

asha-behera and others added 30 commits September 11, 2019 07:41
Change-Id: I5917eb03c44410fcf0aa0ceb5720cd5c12415d00
fix path in on-change subscribe code
Change-Id: I82ec0a1610da009f9906d0ac2ab7c5eb5aa4b13b
* Fix for not showing description when description is configured as part of #show interface command.

* Addressing the crash when max mtu is set as 9276. Currently supported max-mtu is 9216.

* Fix for bugs 96, 97 and 107

* Addressed the comment to sort the speed

* Change MAX_MTU to 9216 in platform_dummy file as well, since it
overwrites it.
merge mgmt-framework bug fixes from Dell - 12th Sept
Change-Id: I2a92251040a816c24f8433e49dd508091dbb494b
Change-Id: Iec675bff98c912ef5d80a2d38524748d6a0b1683
…terface

Change-Id: Ic3e89d74bd399e891a06e14bd4ff7dcd486a9090
Copy link

@renukamanavalan renukamanavalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, please add resolve to all open comments.

models/yang/sonic/sonic-acl.yang Show resolved Hide resolved
models/yang/sonic/sonic-acl.yang Show resolved Hide resolved
models/yang/sonic/sonic-acl.yang Outdated Show resolved Hide resolved
models/yang/sonic/sonic-acl.yang Show resolved Hide resolved
models/yang/sonic/sonic-acl.yang Show resolved Hide resolved
}

leaf alias {
type string;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this mandatory?

models/yang/openconfig-platform.yang Show resolved Hide resolved
models/yang/openconfig-platform.yang Show resolved Hide resolved
models/yang/openconfig-platform.yang Show resolved Hide resolved
models/yang/openconfig-lldp.yang Show resolved Hide resolved
@renukamanavalan
Copy link

Please add a build-check as basic validation, before we push this.

@ranjinidn
Copy link
Contributor

Please add a build-check as basic validation, before we push this.

Checked the build. docker-sonic-mgmt-framework.gz build is successful on release_1.0 branch.

@renukamanavalan
Copy link

Thanks for the confirmation. My request was "to add that as part of checks for this PR".

For example, in case of swss submodule, any PR had to build a the swss submodule (sample here).

Can we add such a test to this submodule ?

src/cvl/Makefile Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet