Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syseeprom] Enable display of vendor extension TLV content #270

Merged
merged 1 commit into from May 2, 2022

Conversation

dflynn-Nokia
Copy link
Contributor

Description

The code that decodes the content of the ONIE syseeprom includes a flag to
enable/disable displaying the content of the vendor extension TLV. This flag is
currently set to 'disable'. Hence the 'show platform syseeprom' command shows
the presence and size of the vendor extension TLV but does not show its
content. This commit sets the flag to 'enable' so that the vendor extension TLV
content is displayed.

Motivation and Context

The 'show platform syseeprom' command shows that the Vendor Extension TLV is present but does not show its content.
Here's what that looks like on an example platform.

admin@sonic:~$ show platform syseeprom

TlvInfo Header:
   Id String:    TlvInfo
   Version:      1
   Total Length: 177
TLV Name             Code Len Value
-------------------- ---- --- -----
Product Name         0x21  11 7215 IXS-T1
Part Number          0x22  14 3HE16794AARB01
Serial Number        0x23  11 NK214810028
Base MAC Address     0x24   6 AC:8F:F8:50:AC:3D
Manufacture Date     0x25  19 11/30/2021 16:53:36
Platform Name        0x28  26 armhf-nokia_ixs7215_52x-r0
ONIE Version         0x29  45 2019.11-onie_version-nokia_ixs7215_52x-v1.5.1
MAC Addresses        0x2A   2 64
Service Tag          0x2F  10 CSM9W00FRA
Vendor Extension     0xFD   7 
CRC-32               0xFE   4 0x21DE1669

How Has This Been Tested?

With this fix in place the command output now looks as follows.

admin@sonic:~$ show platform syseeprom
TlvInfo Header:
   Id String:    TlvInfo
   Version:      1
   Total Length: 177
TLV Name          Code      Len  Value
----------------  ------  -----  ---------------------------------------------
Product Name      0x21       11  7215 IXS-T1
Part Number       0x22       14  3HE16794AA0101
Serial Number     0x23       11  NK204510002
Base MAC Address  0x24        6  50:E0:EF:6E:EC:11
Manufacture Date  0x25       19  11/06/2020 14:45:02
Platform Name     0x28       26  armhf-nokia_ixs7215_52x-r0
ONIE Version      0x29       45  2019.11-onie_version-nokia_ixs7215_52x-v1.5.1
MAC Addresses     0x2A        2  64
Service Tag       0x2F       10  CSM9W00FRA
Vendor Extension  0xFD        7  0x00 0x00 0x19 0x7F 0x01 0x01 0xB5
CRC-32            0xFE        4  0x34885B1D

Additional Information (Optional)

The code that decodes the content of the ONIE syseeprom includes a flag to
enable/disable displaying the content of the vendor extension TLV. This flag is
currently set to 'disable'. Hence the 'show platform syseeprom' command shows
the presence and size of the vendor extension TLV but does not show its
content. This commit sets the flag to 'enable' so that the vendor extension TLV
content is displayed.
@dflynn-Nokia
Copy link
Contributor Author

@sujinmkang Hi Sujin,
I'm curious to get your thoughts on this change.
It seems that displaying the vendor extension field was disabled from Day 1
Not sure why.

@carl-nokia
Copy link

@sujinmkang, have you been able to look at this?
@Blueve, there are three areas with unit test coverage in sonic-platform-common - they are ssd, sfp and thermal --- can we get a pass for this one line change for syseeprom unit test code coverage ?

@sujinmkang sujinmkang merged commit f918125 into sonic-net:master May 2, 2022
itamar-talmon pushed a commit to itamar-talmon/sonic-platform-common that referenced this pull request Jan 12, 2023
…#270)

Description
The code that decodes the content of the ONIE syseeprom includes a flag to
enable/disable displaying the content of the vendor extension TLV. This flag is
currently set to 'disable'. Hence the 'show platform syseeprom' command shows
the presence and size of the vendor extension TLV but does not show its
content. This commit sets the flag to 'enable' so that the vendor extension TLV
content is displayed.
Motivation and Context
The 'show platform syseeprom' command shows that the Vendor Extension TLV is present but does not show its content.
Here's what that looks like on an example platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants