[Evpn Warmreboot] Added Dependancy check logic in VrfMgr #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…into evpn_warmboot
|
Dependant on #1276 |
There is no reconcile operation required in vrfmgrd and intfmgrd Hence immediately after replay these are marked as reconciled
|
retest this please |
1 similar comment
|
retest this please |
prsunny
reviewed
Dec 29, 2020
| @@ -46,7 +46,7 @@ def swss_check_RestoreCount(dvs, state_db, restore_count): | |||
| if fv[0] == "restore_count": | |||
| assert int(fv[1]) == restore_count[key] + 1 | |||
| elif fv[0] == "state": | |||
| assert fv[1] == "reconciled" | |||
| assert fv[1] == "reconciled" or fv[1] == "disabled" | |||
There was a problem hiding this comment.
Do we still need to check for "disabled"? If not, please remove
There was a problem hiding this comment.
Yes, we still need "disabled" to handle the cold restart scenario, specially for docker restart
cfgmgr/intfmgr.cpp
Outdated
| @@ -626,6 +655,7 @@ bool IntfMgr::doIntfAddrTask(const vector<string>& keys, | |||
| void IntfMgr::doTask(Consumer &consumer) | |||
| { | |||
| SWSS_LOG_ENTER(); | |||
| static bool replayNotDone = true; | |||
There was a problem hiding this comment.
can you please rename to "replayDone" and set to false.
There was a problem hiding this comment.
sure .. will change it
|
retest this please |
1 similar comment
|
retest this please |
prsunny
approved these changes
Dec 30, 2020
|
retest this please |
8 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest vs please |
|
retest this please |
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Mar 4, 2021
) * [Evpn Warmreboot] Added Dependancy check logic in VrfMgr This was done to ensure for EVPN warm-reboot the order of data replay to kernel is maintained across various submodules and the kernel programming will be successful. * Marking Vrfmgrd and Intfmgrd to reconcile immediately after replay There is no reconcile operation required in vrfmgrd and intfmgrd, hence immediately after replay these are marked as reconciled
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
#### What I did Modified pre-check for file `/host/warmboot/issu_bank.txt` in `warm-reboot` script. Added automated recovery of `/host/warmboot/issu_bank.txt` #### How I did it Modified the `warm-reboot` script. #### How to verify it Need to somehow corrupt the `/host/warmboot/issu_bank.txt` (list below) and then run the `warm-reboot` command. For testing I have modified the `warm-reboot` script - added corruption command before `check_issu_bank_file` function call. 1. Remove `issu_bank.txt` 2. Clear `issu_bank.txt` 3. Change characters count in `issu_bank.txt` 4. Write invalid content into `issu_bank.txt` #### Previous command output (if the output of a command-line utility has changed) ``` root@arc-switch1041:~# warm-reboot (/host/warmboot/issu_bank.txt) does NOT exist or empty ... To recover (/host/warmboot/issu_bank.txt) file, do the following: $ docker exec -it syncd sx_api_dbg_generate_dump.py $ docker exec -it syncd cat /tmp/sdkdump | grep 'ISSU Bank' Command above will print the VALUE of ISSU BANK - 0 or 1, use this VALUE in the next command $ printf VALUE > /host/warmboot/issu_bank.txt ``` #### New command output (if the output of a command-line utility has changed) ``` root@arc-switch1041:~# warm-reboot (/host/warmboot/issu_bank.txt) does NOT exist or empty ... Recovering the (/host/warmboot/issu_bank.txt) file ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to handel dependency check in VrfMgr for warmreboot
Why I did it
This was done to ensure for EVPN warm-reboot the order of data replay to kernel is maintained across various submodules and the kernel programming will be successful.
How I verified it
Verified with EVPN warmreboot
Details if related
More details in warmreboot section of EVPN VXLAN HLD
sonic-net/SONiC#437