[dvs] Use DB namespace to construct DVSDatabase objects #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <daall@microsoft.com>
|
retest this please |
qiluo-msft
reviewed
Nov 20, 2020
| vs_db_conf_file = f"/tmp/database_config-{self.pid}.json" | ||
|
|
||
| with open(vs_db_conf_file, "w") as f: | ||
| json.dump(db_conf, f) |
There was a problem hiding this comment.
Why not create a vs_db_conf_file under tests directory, as source code, and initialize from it directly?
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Prevent potential kernel oops if drivers are removed/devices are deinitialized while PMon daemons are still trying to access those devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
What I did
I updated the
DVSDatabaseto refer to DBs by name and depend on the database config as opposed to manually providing the IDs and redis socket path.Why I did it
This is the preferred way of addressing databases now, and it's also a much cleaner abstraction than ID/redis socket.
How I verified it
Re-ran the tests w/ this change. Also verified that concurrent tests work as expected.
Details if related