[bufferpool] Support for buffer pool type both #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently sonic supports only 'ingress' and 'egress' types of buffer pools. Since some devices like DNX based switches only support buffer pool type 'both', we are unable to create buffer pools for these devices. This patch fixes this problem by enhancing buffer pool configuration to accept "both" type. The changes include - Changes done to allow orchagent accepting "both" type for buffer pool configuration. - For DOT1P QOS map, the map list was not initialized correctly. So "color" field in the key was sending garbage. Because of this, orchagent serialization function is unable to translate and serialize the attribute value properly and returns warning. During subsequent operation with comes with a different garbage, this was treated as a different "color" and syncd/SAI returns error saying "modification not implemented". This is fixed by initializing the dotp1 map list attribute. Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
|
@neethajohn , @lguohan - please take a look, thanks. |
neethajohn
reviewed
May 13, 2021
As response to code review comments, undid the changes done to fix the dot1p map list initialization fix since this is not related to the title objective of this PR sonic-net#1735 (sonic-net#1735) This fix moved to a different PR sonic-net#1746 (sonic-net#1746) Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com>
ysmanman
approved these changes
May 14, 2021
neethajohn
approved these changes
May 14, 2021
|
@neethajohn - can you please help with merge, thanks! |
4 tasks
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
This PR is fix for the issue sonic-net/sonic-buildimage#7497 Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> What I did Changes done to allow orchagent accepting "both" type for buffer pool configuration. Why I did it Currently sonic supports only 'ingress' and 'egress' types of buffer pools. Since some devices like DNX based switches only support buffer pool type 'both', we are unable to create buffer pools for these devices. This patch fixes this problem by enhancing buffer pool configuration to accept "both" type. How I verified it In a switch that uses DNX arch based chips (like VOQ chassis using line cards with Jerico family of switches), the following configuration is applied "BUFFER_POOL": { "lossless_pool": { "size": "12766208", "type": "both", "mode": "dynamic" } } when the switch became operational, it was observed, there are no error logs indicating invalid parameter or failure of buffer pool creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Changes done to allow orchagent accepting "both" type for buffer pool
configuration.
Why I did it
Currently sonic supports only 'ingress' and 'egress' types of buffer pools.
Since some devices like DNX based switches only support buffer pool
type 'both', we are unable to create buffer pools for these devices.
This patch fixes this problem by enhancing buffer pool configuration to
accept "both" type.
How I verified it
In a switch that uses DNX arch based chips (like VOQ chassis using line cards with Jerico family of switches), the following configuration is applied
when the switch became operational, it was observed, there are no error logs indicating invalid parameter or failure of buffer pool creation.
Details if needed