[cfgmgr/natmgrd] added disabling of NAT feature (Azure#1835) #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KonstiantynHalushka <Konstiantyn_Halushka@jabil.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny please, review this PR |
|
@KonstiantynHalushka Please address my comment. |
|
@AkhileshSamineni Could you tell me exactly what you mean? |
| @@ -97,6 +97,7 @@ void sigterm_handler(int signo) | |||
|
|
|||
| natmgr->cleanupMangleIpTables(); | |||
| natmgr->cleanupPoolIpTable(); | |||
| natmgr->disableNatFeature(); | |||
There was a problem hiding this comment.
@KonstiantynHalushka Instead of "natmgr->disableNatFeature()", calling "natmgr->setFullConeDnatIptablesRule(DELETE);" would be appropriate.
It will clean up the 1.1.1.1 full-cone rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: KonstiantynHalushka Konstiantyn_Halushka@jabil.com
What I did
Added disabling of NAT feature
Why I did it
IP table rule was not removed after config reload (Azure#1835)
How I verified it
sudo config feature state nat enabled
sudo config nat feature enable
sudo iptables -nL -t nat
target prot opt source destination
DNAT all -- 0.0.0.0/0 0.0.0.0/0 to:1.1.1.1 fullcone
Chain INPUT (policy ACCEPT)
target prot opt source destination
Chain POSTROUTING (policy ACCEPT)
target prot opt source destination
Chain OUTPUT (policy ACCEPT)
target prot opt source destination
sudo config reload
sudo iptables -nL -t nat
Chain PREROUTING (policy ACCEPT)
target prot opt source destination
Chain INPUT (policy ACCEPT)
target prot opt source destination
Chain POSTROUTING (policy ACCEPT)
target prot opt source destination
Chain OUTPUT (policy ACCEPT)
target prot opt source destination
Details if related