[202305] Use json.hpp from nlohmann-json-dev instead of from swss-common (#2900) #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c-net#2900) * Use json.hpp from nlohmann-json-dev instead of from swss-common This header file comes from an external package, and a very old version of the header file has been checked into swss-common. This will cause problems for the upcoming Bookworm upgrade. Change references to the header file to use the Debian package nlohmann-json-dev, instead of from swss-common. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
I thought the plan was to change sairedis 202305 branch to not use json.hpp from nlohmann-json-dev? Trying to move everything to use nlohmann-json-dev will be a bigger effort that should not happen on a release branch. |
this change is just cherrypick from master, so we want to move in that direction, why this will be a problem ? |
|
Two reasons:
|
prsunny
changed the title
|
@kcudnik , please link the master PR if you are cherry-picking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header file comes from an external package, and a very old version of the header file has been checked into swss-common. This will cause problems for the upcoming Bookworm upgrade.
Change references to the header file to use the Debian package nlohmann-json-dev, instead of from swss-common.
What I did
Why I did it
How I verified it
Details if related