Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Disregarding EOF status for STREAM subs. #48

Merged
merged 2 commits into from
Nov 18, 2020

Conversation

macikgozwa
Copy link
Contributor

@macikgozwa macikgozwa commented Nov 10, 2020

The client->server stream is not used after sending the subscription list for stream mode subscriptions. Hence closure of that stream is not indicator of end of subscription. Instead check stream.Context() which is signaled once the underlying connection is terminated.

Also see the example service logs and annotations:
service-logs.txt

For testing see the client response output for an ON_CHANGE subscription with query COUNTERS/Ethernet1:

@ghost
Copy link

ghost commented Nov 10, 2020

CLA assistant check
All CLA requirements met.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants