Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all references to new 'sonic-installer' file name #1033

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Update all references to new 'sonic-installer' file name #1033

merged 1 commit into from
Aug 11, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Aug 6, 2020

- Why I did it
sonic_installer has been renamed sonic-installer

- How I did it
Update the application name everywhere it is used

- How to verify it

Test the affected applications. They should work and no longer output the sonic_installer deprecation warning.

@jleveque
Copy link
Contributor Author

jleveque commented Aug 7, 2020

Retest this please

2 similar comments
@jleveque
Copy link
Contributor Author

jleveque commented Aug 8, 2020

Retest this please

@jleveque
Copy link
Contributor Author

jleveque commented Aug 8, 2020

Retest this please

@lguohan
Copy link
Contributor

lguohan commented Aug 8, 2020

is there backward compatibility issue?

@jleveque
Copy link
Contributor Author

jleveque commented Aug 8, 2020

is there backward compatibility issue?

No. There will be a transition period where both sonic_installer and sonic-installer` exist, allowing time for users to make the transition.

Please see the description of the original PR: #983

@jleveque
Copy link
Contributor Author

jleveque commented Aug 8, 2020

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque jleveque merged commit 7ae8024 into sonic-net:master Aug 11, 2020
@jleveque jleveque deleted the update_sonic-installer branch August 11, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants