Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify port status in APPL_DB after shutting down interfaces. #1310

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Verify port status in APPL_DB after shutting down interfaces. #1310

wants to merge 5 commits into from

Conversation

praveen-li
Copy link

Depends on #1303

- What I did

Verify Port status in APPDB after shutting down the interfaces before starting deletion of Ports.

- How I did it
DB Connect to APPDB and check operational status of all ports which are being deleted.

- How to verify it

Build with new Tests in tests/config_mgmt_test.py:

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@praveen-li
Copy link
Author

Gentle Reminder for review.

@praveen-li
Copy link
Author

@jleveque
Kindly label it with Port Breakout 🔱. thx

@allas-nvidia
Copy link
Contributor

Kindly reminder to merge it. (resolve conflicts)
Can be labeled with 202012?
Thanks

@allas-nvidia
Copy link
Contributor

@praveen-li
Function _checkKeyinAsicDB was removed, but it is still being used in _checkNoPortsInAsicDb
I think that function _checkKeyinAsicDB was changed to checkKeyinAsicDB
can you please take a look?
Thanks

qiluo-msft
qiluo-msft reviewed Apr 13, 2021
View reviewed changes
config/config_mgmt.py Outdated Show resolved Hide resolved
@praveen-li
Copy link
Author

@qiluo-msft : This is dependent of #1303 , kindly review only 2nd commit in this PR.
If we can merge #1303 , I can rebase it. Thx.

@praveen-li
Copy link
Author

@praveen-li
Function _checkKeyinAsicDB was removed, but it is still being used in _checkNoPortsInAsicDb
I think that function _checkKeyinAsicDB was changed to checkKeyinAsicDB
can you please take a look?
Thanks

the diff is shown that way, I am not removing _checkKeyinAsicDB, it is moved to _checkKeyInAsicDB

@praveen-li praveen-li changed the title Verify port status app db Verify port status in APPL_DB after shutting down interfaces. May 12, 2021
Praveen Chaudhary and others added 5 commits June 22, 2021 18:34
[config_mgmt.py]: Verify port status down in APPL DB.
dcab8d5 
Changes:
-- Verify port status down in APPL DB after shutting down the ports.
-- Tests.

Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
Corrent name for _checkKeyInAsicDB
a949cd3
MagicMock --> mock.MagicMock
1b42a18
use load_module_from_source
21ade5f
add mock for _verifyAppDB in config_dpb_test.py
b4cdbd3
@praveen-li
Copy link
Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1310 in repo Azure/sonic-utilities

@qiluo-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft left review comments

@daall daall daall left review comments

@jleveque jleveque Awaiting requested review from jleveque

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Enhancement Port Breakout 🔱
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@praveen-li @allas-nvidia @qiluo-msft @jleveque @daall @zhenggen-xu