Add script to block/unblock ICMP traffic on a given ACL table [experimental; do not merge] #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 10, 2021
qiluo-msft
reviewed
Mar 10, 2021
scripts/set_icmp_state
Outdated
| table_ip_version = 6 if table_ip_version == IP_VERSION_V6 else 4 | ||
| if destination_ip_version != table_ip_version: | ||
| error("Cannot use an IPv{} rule with an IPv{} table, exiting...".format(destination_ip_version, table_ip_version)) | ||
| except Exception as e: |
There was a problem hiding this comment.
Exception [](start = 11, length = 9)
Is there a more specific exception type? #Closed
There was a problem hiding this comment.
Per the docs it will be a ValueError, so we can check for that.
qiluo-msft
reviewed
Mar 10, 2021
qiluo-msft
reviewed
Mar 10, 2021
qiluo-msft
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)