Potential risk of acl_loader missing ctx in main function #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potential risk about cli() function without ctx in main function of acl_loader Root cause: SONiC will call cli() directly in acl-loader. But it still exist potential risk when run main in acl-loader Solution: Remover main funcion which missing ctx object and remain cli() function for acl-loader call directly
|
@lguohan could you help to review it? |
|
@qiluo-msft , can you check this pr? |
qiluo-msft
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Potential risk about cli() function without ctx in main function of acl_loader
Root cause:
SONiC will call cli() directly in acl-loader.
But it still exist potential risk when run main in acl-loader
Solution:
Remover main funcion which missing ctx object and remain cli() function for acl-loader call directly