Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: install core tools automatically when needed (closes #353) #391

Merged
merged 13 commits into from
Mar 4, 2022
Merged

feat: install core tools automatically when needed (closes #353) #391

merged 13 commits into from
Mar 4, 2022

Conversation

sinedied
Copy link
Member

@sinedied sinedied commented Feb 25, 2022 •
edited

Best description is a short demo:
func2

馃帀

What this PR does:

  • Check if Core Tools are installed globally
  • If not or if the global Core Tools version doesn't match the required Node.js runtime, it will install a local version shared among all CLI instances (installed in ~/.swa/core-tools
  • Multiple major versions of local Core Tools can coexist, for example v3 if you have a Node v12 project and v4 for a Node v16 projects (if you're using NVM for example)
  • Use local Core Tools version when available

@github-actions github-actions bot added the scope: core Issues happened a the ./src/core level label Feb 25, 2022
@sinedied sinedied mentioned this pull request Feb 25, 2022
Closed
manekinekko
manekinekko requested changes Mar 1, 2022
View reviewed changes
src/core/func-core-tools.ts Outdated Show resolved Hide resolved
src/core/func-core-tools.ts Outdated Show resolved Hide resolved
src/core/func-core-tools.ts Outdated Show resolved Hide resolved
src/core/func-core-tools.ts Show resolved Hide resolved
@sinedied
Copy link
Member Author

sinedied commented Mar 4, 2022

All comments should have been resolved, there're now more testing code that actual code 馃槄

@manekinekko manekinekko merged commit 5e98cba into Azure:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekinekko manekinekko manekinekko approved these changes

@anthonychu anthonychu Awaiting requested review from anthonychu

@tkamesh tkamesh Awaiting requested review from tkamesh

@sgollapudi77 sgollapudi77 Awaiting requested review from sgollapudi77

Assignees

@sinedied sinedied

Labels
scope: core Issues happened a the ./src/core level
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinedied @manekinekko