Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use azurerm_key_vault_certificate_contacts instead #25

Closed
davidkarlsen opened this issue Nov 5, 2023 · 8 comments · Fixed by #113
Closed

Use azurerm_key_vault_certificate_contacts instead #25

davidkarlsen opened this issue Nov 5, 2023 · 8 comments · Fixed by #113
Assignees
Labels
bug Something isn't working

Comments

@davidkarlsen
Copy link

See hashicorp/terraform-provider-azurerm#19743 and hashicorp/terraform-provider-azurerm#10256 - it might be more optimal to use azurerm_key_vault_certificate_contacts to avoid permission problem when initially creating the KV.

@davidkarlsen
Copy link
Author

ah, nvm, this is of course on the consuming-side of things.

@matt-FFFFFF
Copy link
Member

Thanks for this. We will consider the implementation detail.

We do not support access policies in the module as yet, preferring Azure role assignments.

In your use case, how would the above affect the use of the dedicated contact resource?

@davidkarlsen
Copy link
Author

davidkarlsen commented Nov 5, 2023

you get a permission denied because the IAM has not been assigned yet - so instead you do this sequence:

  1. create KV
  2. create IAM
  3. create contact resource, depending on 2)

@matt-FFFFFF
Copy link
Member

Thanks. Will swap it out and make dependent on the role assignments

@matt-FFFFFF matt-FFFFFF added the bug Something isn't working label Nov 5, 2023
@matt-FFFFFF matt-FFFFFF reopened this Nov 5, 2023
@davidkarlsen
Copy link
Author

could this be merged and released?

@matt-FFFFFF
Copy link
Member

Hi, I've put this in another PR that's challenging at the moment.

I can pull it out.

@davidkarlsen
Copy link
Author

@matt-FFFFFF fix in #39

@matt-FFFFFF matt-FFFFFF self-assigned this Jan 9, 2024
@matt-FFFFFF matt-FFFFFF linked a pull request Jun 10, 2024 that will close this issue
11 tasks
@matt-FFFFFF
Copy link
Member

now fixed by #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment