Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additional variable validation for secrets #71

Closed
kewalaka opened this issue Feb 6, 2024 · 1 comment · Fixed by #113
Closed

feat: additional variable validation for secrets #71

kewalaka opened this issue Feb 6, 2024 · 1 comment · Fixed by #113
Labels
enhancement New feature or request

Comments

@kewalaka
Copy link

kewalaka commented Feb 6, 2024

add validation conditions for these:

secret name:

Error: "name" may only contain alphanumeric characters and dashes

expiration date & not before date:

expected "expiration_date" to be a valid RFC3339 date, e.g. "2006-01-02T15:04:05Z07:00"
expected "not_before_date" to be a valid RFC3339 date, e.g. "2006-01-02T15:04:05Z07:00"
@matt-FFFFFF matt-FFFFFF added the enhancement New feature or request label Feb 6, 2024
@lestermarch lestermarch mentioned this issue Mar 28, 2024
Closed
11 tasks
@matt-FFFFFF matt-FFFFFF linked a pull request Jun 10, 2024 that will close this issue
fix!: latest avm standards #113
Merged
11 tasks
@matt-FFFFFF
Copy link
Member

implemented by #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
AVM - Module Issues
Status: Done
Milestone
No milestone
2 participants
@kewalaka @matt-FFFFFF