Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency on Azure Account extension #566

Closed
peterbom opened this issue Mar 18, 2024 · 1 comment · Fixed by #551
Closed

Remove Dependency on Azure Account extension #566

peterbom opened this issue Mar 18, 2024 · 1 comment · Fixed by #551
Assignees
Labels
enhancement 🚀 New feature or request or improvements on existing code.

Comments

@peterbom
Copy link
Collaborator

peterbom commented Mar 18, 2024

Is your feature request related to a problem? Please describe.
There are some problems with depending on the Azure Account extension:

  1. It adds extra 'weight' to our extension, by forcing users to install something they may not want or use.
  2. It is now deprecated.
  3. Upcoming work that requires Azure credentials will make our extension more deeply coupled to the Azure Account extension, making it harder to make these changes later.
  4. There is a long-standing bug with it that prevents us retrieving credentials needed for other Azure SDKs in the recommended manner (using a VisualStudioCodeCredential)
  5. It uses a separate sign-in and credential handling experience from the VS Code Authentication API. This means it doesn't pick up the user's session(s) visible in the Account menu:
    image

Mention what platform you want to support the new feature
All platforms

Describe the solution you'd like

  • Users not to be forced to install the Azure Account extension
  • To be able to use the VS Code API for getting authentication sessions
  • For the Account view to match the Cloud Explorer tree view

Describe alternatives you've considered
None, although the approach is discussed in the associated PR.

Additional context

@peterbom peterbom added the enhancement 🚀 New feature or request or improvements on existing code. label Mar 18, 2024
@peterbom peterbom self-assigned this Mar 18, 2024
@Tatsinnit Tatsinnit pinned this issue Mar 19, 2024
@Tatsinnit Tatsinnit linked a pull request Mar 19, 2024 that will close this issue
@peterbom
Copy link
Collaborator Author

This will be addressed by #551. Some notes about the changes in appearance and behaviour:

  1. After first upgrading to the version of the extension which has these changes, users will no longer be signed in on the Cloud Explorer tree view, which will look like this:
    Screenshot 2024-03-26 105457
  2. After selecting the option to sign in (either from the tree view itself or using the "AKS: Sign in to Azure..." command), users will be presented with a confirmation dialog:
    Screenshot 2024-03-26 105623
  3. Due to a limitation of the VS Code authentication API there is no way for our extension to cancel an authentication request after launching a browser tab. That means if users close that tab without completing the sign-in, Cloud Explorer will get stuck in "waiting" state until the VS Code window is reloaded:
    Screenshot 2024-03-26 143515
  4. To switch between tenants users will need to run the "AKS: Sign in to Azure..." command and select "Sign in to another account":
    Screenshot 2024-03-26 144111
  5. If users had been filtering the subscriptions in the Cloud Explorer tree view using the "Select subscriptions" functionality of the Azure Account extension, those filters will continue working. These are stored by the Azure Account extension in the azure.ResourceFilter setting:
    Screenshot 2024-03-26 105058
  6. The selected subscriptions can be changed using the "AKS: Select subscriptions" command:
    Screenshot 2024-03-26 144335
  7. If the selected subscriptions are changed, they will be stored in user settings under the aks.selectedSubscriptions section:
    Screenshot 2024-03-26 145311
  8. The VS Code "Accounts" menu will now contain the account used to sign in to the Cloud Explorer tree view. Signing out of the Microsoft accounts will also sign the user out from the tree view:
    Screenshot 2024-03-26 145756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🚀 New feature or request or improvements on existing code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant