Don't apply a language config to the output window #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #389. |
bnookala
approved these changes
Oct 25, 2018
itowlson
force-pushed
the
dont-trample-on-output-configuration
branch
from
27fc823
to
7b83d6d
Compare
bnookala
pushed a commit
to brendandburns/vscode-kubernetes-tools
that referenced
this pull request
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We applied a language setting to the output window's MIME type in order to colourise headers for output printed to that window (#28). Unfortunately, this hijacks the language away from the VS Code
Log'language', resulting in the default linkifier not running on stuff in the output window. This means that when, say, test runners output line references to the output window, those references cease to be linkified (#389).Losing links in test runs is worse than having to grovel for command headers in k8s output, so let's remove the colourisation.