You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Hey @glaubitz thanks for your report! Different locale support has always been a hard-to-test problem.
In this particular case, we are already using UTF-8 for source code encoding, which is the Python default encoding. Besides, there is no practical way to ensure dos2unix would be run at every time after we modify our source file.
I believe the right solution would be to explicitly use UTF-8 when attempting to read the file. I create a tentative fix for that, and it passes my local simulation test based on my theory. However I don't exactly have your locale environment to reproduce the issue in the first place, so I would like to have your help to test it out. Would you mind pull my experimental branch enforcing-utf8-on-version-detection into your environment and build your RPM again? If it works well, let me know and I will merge my branch.
The
setup.py
script parses the version number from theadal/__init__.py
. This can fail with certain locales on Linux when Python3 is being used:This is because of the Windows encoding of
__init__.py
contains a byte-order mark at the beginning of the file:simply converting
__init__.py
to standard Unix format fixes the problem:This problem also affects the building of RPM packages. In fact, I stumbled over this issue when trying to build the python3 RPM package for ADAL.
Please consider plain UTF-8 for the source code encoding.
The text was updated successfully, but these errors were encountered: