New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate log keyID for IDX10503 #2604

Open

RetYn opened this issue May 22, 2024 · 0 comments

Labels

Good First Issue

RetYn commented May 22, 2024 •

edited

Loading

Summary

The log message for IDX10503 in this https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2436/files is duplicated:

key.ToString already contains the key.keyId in it.
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/src/Microsoft.IdentityModel.Tokens/SecurityKey.cs

In addition, I don't think it's necessary to print the InternalId which is the thumbprints of the public key in the log.

RetYn changed the title ~~Duplicate log message for IDX10503~~ Duplicate log key ID for IDX10503

RetYn changed the title ~~Duplicate log key ID for IDX10503~~ Duplicate log keyID for IDX10503

kellyyangsong added the Good First Issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment