Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Remove default method implementations on TokenHandler #2632

Closed
keegan-caruso opened this issue Jun 13, 2024 · 1 comment
Closed

[Feature Request] Remove default method implementations on TokenHandler #2632

keegan-caruso opened this issue Jun 13, 2024 · 1 comment
Labels
IdentityModel8x Future breaking issues/features for IdentityModel 8x

Comments

@keegan-caruso
Copy link
Contributor

keegan-caruso commented Jun 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
It is better for an abstract class to not have default implementations that only throw.

Describe the solution you'd like
It is a breaking change, but implementors of TokenHandler should have to implement all abstract methods themselves.
@keegan-caruso keegan-caruso added the IdentityModel8x Future breaking issues/features for IdentityModel 8x label Jun 13, 2024
@keegan-caruso
Copy link
Contributor Author

See the comments in #2663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IdentityModel8x Future breaking issues/features for IdentityModel 8x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keegan-caruso