Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

Infinite loop when trying to login to website from iOS 12 #1329

Closed
2 of 7 tasks
daemnin opened this issue Oct 17, 2018 · 6 comments
Closed
2 of 7 tasks

Infinite loop when trying to login to website from iOS 12 #1329

daemnin opened this issue Oct 17, 2018 · 6 comments

Comments

@daemnin
Copy link

daemnin commented Oct 17, 2018

Which Version of ADAL are you using ?
ADAL 3.19.8

Which platform has the issue?
.NET Core 2.1

What authentication flow has the issue?

  • Desktop / Mobile
    • Interactive
    • Integrated Windows Auth
    • Username Password
    • Device code flow (browserless)
  • Web App
    • Authorization code
    • OBO
  • Web API
    • OBO

Repro
Minimal repository

Expected behavior
The user can use his/her credentials to access the website and then retrive an access token for an API call.

Actual behavior
When an iOS user enters his/hers credentials and click the Login button it redirects to the website (as expected) but then the website redirects again to login.microsoftonline.com and keeps doing this back and forwards leaving the user in an infinite loop. If the user stops the browser and try to access the website's url again, it will load the correctly with the session started.

This happens only on iOS. It works on Mac OS, Windows and Android. The site where this was implemented was working correctly a few weeks back.

Possible Solution
I think it's related to how iOS handles the cookies but I'm not sure.

@jmprieur
Copy link
Contributor

@daemnin : do you see this any iOS version? or only iOS 12?
could it be related to https://bugs.webkit.org/show_bug.cgi?id=188165 ?

@daemnin
Copy link
Author

daemnin commented Oct 17, 2018

@jasoncoolmax I've only test this on devices with iOS 12, But it seems strange since we have another website using the same AAD with similar configurations but running on .NET Core 1.1 and an older version of adal and that website has no issues

@daemnin
Copy link
Author

daemnin commented Oct 17, 2018

@jmprieur after reading though the comments in the link you posted, it seems that is the same bug but the workaround posted there isn't working for me. It is not giving me a Principal in the AuthorizationCodeReceivedContext

@jmprieur
Copy link
Contributor

@henrik-me : another iOS12 ...

@henrik-me
Copy link
Contributor

@jennyf19

@jmprieur jmprieur changed the title Infinite loop when trying to login to website from iOS Infinite loop when trying to login to website from iOS12 Oct 18, 2018
@jmprieur jmprieur changed the title Infinite loop when trying to login to website from iOS12 Infinite loop when trying to login to website from iOS 12 Oct 18, 2018
@jennyf19
Copy link
Contributor

@daemnin The asp.net team has issued this security advisory https://github.com/aspnet/Security/issues/1864

I'm closing this issue, as it is external to the library.

cc: @jmprieur @henrik-me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants