Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing ADAL module results in build error (v 2.2.1) #693

Closed
eddiekim opened this issue Jul 6, 2016 · 3 comments
Closed

Importing ADAL module results in build error (v 2.2.1) #693

eddiekim opened this issue Jul 6, 2016 · 3 comments
Labels
Milestone

Comments

@eddiekim
Copy link
Contributor

eddiekim commented Jul 6, 2016

I get build errors on v2.2.1 when semantically importing the ADAL module (import ADAL). This was fine in v2.2.0, and appears to be related to commit 91d7000 . Seems that Xcode doesn't like that the same header files are made available by both the ADALiOS static library and ADAL framework by the same path.

adal-module-error

To reproduce in MyTestiOSApp:

  • Remove libADALiOS.a from Linked Frameworks and Libraries
  • Add ADAL.framework to Embedded Binaries
  • Replace #import <ADAL/ADAL.h> with @import ADAL; in ADTestAppDelegate.m
  • Result: error: include of non-modular header inside framework module 'ADAL'
  • Workaround: go to Build Phases for ADALiOS static library and change Copy Files Subpath to something else (anything)
  • Clear derived data and build again
  • Result: Build success
@RPangrle
Copy link
Contributor

RPangrle commented Jul 8, 2016

Unfortunately that change was made so that applications only using the static libraries can import headers properly. The only way I can think around this is to not have the ADAL framework rely on the ADALiOS static lib

@eddiekim
Copy link
Contributor Author

eddiekim commented Jul 8, 2016

I think you will have more people who prefer framework to static libs going forward, so it's something to think about. As-is, it doesn't seem like you can use the ADAL framework unless you build it outside of the client project first (or make changes to the Xcode project)

This isn't really an issue for us anymore, so feel free to close.

@RPangrle
Copy link
Contributor

RPangrle commented Aug 9, 2016

I've done some work to mitigate this. The static lib build has been split into two libs, one that'll copy headers and one that won't. This way you'll be able to include the xcode project in your project and choose framework or static libs, you won't be able to do both though.

@RPangrle RPangrle closed this as completed Aug 9, 2016
@RPangrle RPangrle added this to the 2.2.3 milestone Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants