Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Chinese Characters #819

Closed
corbinreynolds opened this issue Oct 28, 2016 · 0 comments · Fixed by #822
Closed

Crash with Chinese Characters #819

corbinreynolds opened this issue Oct 28, 2016 · 0 comments · Fixed by #822
Assignees
Milestone

Comments

@corbinreynolds
Copy link

corbinreynolds commented Oct 28, 2016

ADAuthenticationContext.acquireTokenWithResource includes an extraQueryParameters parameter. We are seeing an exception / crash when Chinese characters are used in the domain name of the login_hint passed in the extraQueryParameters parameter.

The result is that the startUrl is nil when ADWebAuthController is initialized and an exception is thrown, crashing the app.

Instead of throwing an exception (in non DEBUG environments), this should make it's way back up the stack and be returned as success = false in the ADAuthenticationContext.acquireTokenWithResource call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants