Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP API Tests Fail in TravisCI #21

Closed
marstr opened this issue May 22, 2019 · 3 comments
Closed

DP API Tests Fail in TravisCI #21

marstr opened this issue May 22, 2019 · 3 comments

Comments

@marstr
Copy link
Collaborator

marstr commented May 22, 2019

Some thing about the Windows Build Machines in TravisCI will not allow DP API calls. Each time, an OSError with errno=5 is returned.

These scenarios work on individual's machines, which means the core scenarios of this library are met. However, we need to figure out what it is about the TravisCI build machines is preventing this from working and either fix-it or understand the problem well enough to permanently skip these tests in CI. Until that investigation is done, a TODO is going in the code-base to fix this issue.

@henrik-me
Copy link

@marstr : is this issue still relevant?

@rayluo rayluo removed the bug Something isn't working label Oct 26, 2019
@rayluo
Copy link
Contributor

rayluo commented Oct 26, 2019

I remember Martin used this issue as a memo. This was more about our known observation on Travis-CI's behavior, and less about an actual bug on our side.
I think we can keep it as-is, revisit this when we would start a second wave of effort on this Extensions module in future.

@rayluo
Copy link
Contributor

rayluo commented May 20, 2020

Decided to close this.

We simply recorded such observation in our test case. FWIW, encryption won't work on headless Linux either. There is not much else we can do about it.

We are still confident of our code's quality here, because those encryption-relevant code path were manually tested while we implemented/modified them. Since then they remain stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants