Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MSAL will not perform silent auth when broker is enabled and not installed. #1809

Closed
1 of 8 tasks
trwalke opened this issue May 7, 2020 · 0 comments
Closed
1 of 8 tasks
Assignees
Labels
Milestone

Comments

@trwalke
Copy link
Member

trwalke commented May 7, 2020

Normally, if the broker is configured for use (WithBroker(true)) then MSAL will only attempt silent authentication through the broker. This is because the android broker does not return a RT to be stored in the cache. However, this does not mean that it is impossible for a valid RT to be in the cache ready for silent authentication. Therefore, MSAL should check its internal cache for a valid token even if the broker is not installed.

Which Version of MSAL are you using ?
4.13

Platform
Xamarin android

What authentication flow has the issue?

  • Desktop / Mobile
    • Interactive
    • Silent
    • Integrated Windows Auth
    • Username Password
    • Device code flow (browserless)
  • Web App
    • Authorization code
    • OBO
  • Web API
    • OBO

Repro
Acquire a token interactively without broker to put a token in the cache. Then, acquire a token silently with broker uninstalled and using the WithBroker(true) api.

Expected behavior
MSAL should check to see if the broker is installed and then perform silent authentication locally

Actual behavior
MSAL returns an exception stating that the broker is required.

Possible Solution
Allow MSAL to perform sign in locally when the broker app is not available as a fallback

@trwalke trwalke added this to the 4.14.0 milestone May 7, 2020
@trwalke trwalke added this to Todo/Committed in MSAL.NET (legacy) via automation May 7, 2020
@trwalke trwalke moved this from Todo/Committed to In progress in MSAL.NET (legacy) May 7, 2020
@trwalke trwalke self-assigned this May 7, 2020
@trwalke trwalke moved this from In progress to Fixed in MSAL.NET (legacy) May 14, 2020
@bgavrilMS bgavrilMS moved this from Fixed to In progress in MSAL.NET (legacy) May 14, 2020
@bgavrilMS bgavrilMS moved this from In progress to Fixed in MSAL.NET (legacy) May 15, 2020
@bgavrilMS bgavrilMS removed this from Fixed in MSAL.NET (legacy) May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants