Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] GetDeviceId sometimes takes 1.5s #1912

Closed
bgavrilMS opened this issue Jul 2, 2020 · 1 comment
Closed

[Bug] GetDeviceId sometimes takes 1.5s #1912

bgavrilMS opened this issue Jul 2, 2020 · 1 comment
Assignees
@bgavrilMS
Labels
bug VS
Projects
MSAL.NET (legacy)
Milestone
4.17.0

Comments

@bgavrilMS
Copy link
Member

Which Version of MSAL are you using ?
4.15

Platform
.net classic

Repro

Expected behavior
AcquireTokenSilent normally takes ~300ms

Actual behavior
AcquireTokenSilent sometimes takes ~2s, whith a lot of time spent in GetDeviceId

Possible Solution
GetDeviceId on .net classic tries to enumerate the system NICs and use a network address as id. This can take a very long time when a VPN is configured on the system.

We should not call "get device id" because it is used in conjuction with MATS Telemetry. We do not use MATS telemetry at the moment.
@bgavrilMS bgavrilMS added this to the 4.17.0 milestone Jul 2, 2020
@bgavrilMS bgavrilMS added this to Todo/Committed in MSAL.NET (legacy) via automation Jul 2, 2020
@bgavrilMS bgavrilMS moved this from Todo/Committed to vNext in MSAL.NET (legacy) Jul 2, 2020
@bgavrilMS bgavrilMS moved this from vNext to Todo/Committed in MSAL.NET (legacy) Jul 13, 2020
@bgavrilMS bgavrilMS moved this from Todo/Committed to In progress in MSAL.NET (legacy) Jul 14, 2020
@bgavrilMS bgavrilMS mentioned this issue Jul 15, 2020
Merged
@bgavrilMS bgavrilMS moved this from In progress to Fixed in MSAL.NET (legacy) Jul 16, 2020
@bgavrilMS bgavrilMS self-assigned this Jul 16, 2020
@neha-bhargava
Copy link
Contributor

Fixed in MSAL 4.17.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgavrilMS bgavrilMS

Labels
bug VS
Projects
No open projects
MSAL.NET (legacy)
  
Fixed
Milestone
4.17.0
Development

No branches or pull requests
2 participants
@bgavrilMS @neha-bhargava