Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Sometimes the status code returned in broker error messages is not parsed in the right format #2062

Closed
1 of 7 tasks
trwalke opened this issue Sep 29, 2020 · 0 comments
Closed
1 of 7 tasks

[Bug] Sometimes the status code returned in broker error messages is not parsed in the right format #2062

trwalke opened this issue Sep 29, 2020 · 0 comments
Assignees
@trwalke
Labels
bug P1
Projects
MSAL.NET (legacy)
Milestone
4.20.0

Comments

@trwalke
Copy link
Member

trwalke commented Sep 29, 2020

Which Version of MSAL are you using ?
4.19

Platform
xamarin android

What authentication flow has the issue?

  • Desktop / Mobile
    • Interactive
    • Integrated Windows Auth
    • Username Password
    • Device code flow (browserless)
  • Web App
    • Authorization code
    • OBO
  • Web API
    • OBO

Repro
Expected behavior
MSAL should properly parse http status codes broker error messages

Actual behavior
MSAL will sometimes fail to parse these properly.

Possible Solution
Refactor broker code to better parse error messages.
@trwalke trwalke self-assigned this Sep 29, 2020
@trwalke trwalke added the bug label Sep 29, 2020
@trwalke trwalke added this to the 4.20.0 milestone Sep 29, 2020
@trwalke trwalke added this to Todo/Committed in MSAL.NET (legacy) via automation Sep 29, 2020
@trwalke trwalke changed the title [Bug] Sometimes the status code does in broker error messages is not in the right format [Bug] Sometimes the status code returned in broker error messages is not in the right format Sep 29, 2020
@trwalke trwalke changed the title [Bug] Sometimes the status code returned in broker error messages is not in the right format [Bug] Sometimes the status code returned in broker error messages is not parsed in the right format Sep 29, 2020
@trwalke trwalke mentioned this issue Sep 30, 2020
Merged
@henrik-me henrik-me moved this from Todo/Committed to In Progress in MSAL.NET (legacy) Oct 1, 2020
@henrik-me henrik-me added the P1 label Oct 1, 2020
@trwalke trwalke added Fixed and removed In Progress labels Oct 2, 2020
@trwalke trwalke moved this from In Progress to Fixed in MSAL.NET (legacy) Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwalke trwalke

Labels
bug P1
Projects
No open projects
MSAL.NET (legacy)
  
Fixed
Milestone
4.20.0
Development

No branches or pull requests
3 participants
@bgavrilMS @trwalke @henrik-me