Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] add an override of the constructor of PopAuthenticationConfiguration with an HttpVerb parameter #2285

Closed
trwalke opened this issue Dec 8, 2020 · 0 comments · Fixed by #2840
Closed

[Feature Request] add an override of the constructor of PopAuthenticationConfiguration with an HttpVerb parameter #2285

trwalke opened this issue Dec 8, 2020 · 0 comments · Fixed by #2840
Labels
Feature Request P2

Comments

@trwalke
Copy link
Member

trwalke commented Dec 8, 2020 •
edited
Loading

Describe the solution you'd like
Add an override of the constructor of PopAuthenticationConfiguration with an HttpVerb parameter so that this is more discoverable. There should also be a property to allow changes after initialization of the configuration object.

Additional context
This is a minor modification to this feature here: POP
@trwalke trwalke added this to Todo/Committed in MSAL.NET (legacy) via automation Dec 8, 2020
@trwalke trwalke added this to the 4.25.0 milestone Dec 8, 2020
@jmprieur jmprieur added the P2 label Dec 9, 2020
@bgavrilMS bgavrilMS modified the milestones: 4.25.0, 4.26.0 Jan 14, 2021
@bgavrilMS bgavrilMS modified the milestones: 4.26.0, 4.27.0 Jan 26, 2021
@trwalke trwalke modified the milestones: 4.27.0, 4.28.0 Feb 19, 2021
@bgavrilMS bgavrilMS removed this from the 4.28.0 milestone Mar 18, 2021
@bgavrilMS bgavrilMS removed this from Todo in MSAL.NET (legacy) Apr 20, 2021
@jmprieur jmprieur mentioned this issue Aug 24, 2021
Merged
@bgavrilMS bgavrilMS linked a pull request Aug 24, 2021 that will close this issue
Add custom nonce support to POP #2840
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom nonce support to POP AzureAD/microsoft-authentication-library-for-dotnet
3 participants
@bgavrilMS @jmprieur @trwalke