Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCA - obsolete via warning GetAccountsAsync() in favour of GetAccountsAsync(home_account_id) #2462

Closed
pmaytak opened this issue Mar 9, 2021 · 3 comments
Assignees
Milestone

Comments

@pmaytak
Copy link
Contributor

pmaytak commented Mar 9, 2021

For confidential client apps, obsolete via warning GetAccountsAsync() in favour of GetAccountsAsync(home_account_id).

@pmaytak pmaytak added this to the 4.28.0 milestone Mar 9, 2021
@pmaytak pmaytak self-assigned this Mar 9, 2021
@pmaytak pmaytak added this to Todo in MSAL.NET (legacy) via automation Mar 9, 2021
@jmprieur
Copy link
Contributor

jmprieur commented Mar 9, 2021

@pmaytak it seems to me that this is a duplicate of #1967, which BTW is better spec-ed than this issue, as it provides the message, including the aka.ms link ?

@bgavrilMS
Copy link
Member

Closing as duplicate

@jmprieur
Copy link
Contributor

jmprieur commented Mar 9, 2021

FYI, I've updated the description in the duplicated issue.

Proposed spec
in IConfidentialClientApplication, add a new method (with the same signature as in the base interface):

        /// <inheritdoc/>
        [Obsolete("Use GetAccountAsync in web apps and web APIs, and use a token cache serializer for better security and performance. See https://aka.ms/msal-net-cca-token-cache-serialization.")]
        new Task<IEnumerable<IAccount>> GetAccountsAsync()

@bgavrilMS bgavrilMS removed this from Todo in MSAL.NET (legacy) Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants