Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Deprecate Old WAM #3447

Closed
gladjohn opened this issue Jul 5, 2022 · 5 comments · Fixed by #3984
Closed

[Feature Request] Deprecate Old WAM #3447

gladjohn opened this issue Jul 5, 2022 · 5 comments · Fixed by #3984
Assignees
Milestone

Comments

@gladjohn
Copy link
Contributor

gladjohn commented Jul 5, 2022

Is your feature request related to a problem? Please describe.
Explore options on how to deprecate the old WAM broker

Describe the solution you'd like
need to explore possible solutions

Describe alternatives you've considered
none

Additional context
This will make the new broker the only option in MSAL .Net for WAM

@gladjohn gladjohn added this to Triage in MSAL.NET (legacy) via automation Jul 5, 2022
@jmprieur jmprieur modified the milestones: 4.46.0, 5.0.0 Jul 5, 2022
@bgavrilMS
Copy link
Member

bgavrilMS commented Jul 6, 2022

@jmprieur - I was thinking we do this as part of 4.x ? Here's how I see this done:

  1. Figure out how to inject functionality from MIcrosot.Identity.Client.Broker in MSAL. Currently this is done via "WithBrokerPreview". We can leave this as is and I was thinking of removing "WithBroker" from net4*, netstandard and netcore and replacing it with MIcrosot.Identity.Client.Broker.WithBroker. Suggestions welcome.

  2. Deprecate Microsoft.Identity.Client.Desktop package via nuget message which recommends use of MIcrosot.Identity.Client.Broker package instead.

ALTERNATIVE:

  1. Deprecate MIcrosot.Identity.Client.Broker and move all functionality to Microsoft.Identity.Client.Desktop. Should be a drop-in replacement, but we cannot gurantee that the exact scenarios will work.

It's true that Microsoft.Identity.Client.Desktop also has WebView2 support for B2C. I suggest we drop this for now and update our desktop sample instead (the CustomWebUI version). Also, we need to wait for the last missing feature from runtime, i.e. account discovery.

CC @pmaytak @trwalke @neha-bhargava @sameerkapps for suggestions

@jmprieur
Copy link
Contributor

jmprieur commented Jul 6, 2022

@bgavrilMS : I guess I would need to see the before / after in term of API / DevEx to fully understand

@gladjohn
Copy link
Contributor Author

gladjohn commented Jan 20, 2023

@bgavrilMS

do we have a final plan on the deprecation of the old broker? are we doing the alternative approach?

"Deprecate MIcrosot.Identity.Client.Broker and move all functionality to Microsoft.Identity.Client.Desktop. Should be a drop-in replacement, but we cannot gurantee that the exact scenarios will work."

Or

"Deprecate Microsoft.Identity.Client.Desktop package via nuget message which recommends use of MIcrosot.Identity.Client.Broker package instead." and GA the new broker. But the older broker (Desktop) can be used for WebView2 and UWP

@SameerK-MSFT @neha-bhargava @trwalke @pmaytak other ideas?

@gladjohn
Copy link
Contributor Author

gladjohn commented Jan 25, 2023

@SameerK-MSFT assigning this to you since you are working on finalizing the design

@gladjohn
Copy link
Contributor Author

Adding this to in-progress to track the deprecation of the old broker and for naming the new APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants