Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Authority Validation enhacements #3775

Closed
3 tasks done
bgavrilMS opened this issue Oct 31, 2022 · 1 comment · Fixed by #3818
Closed
3 tasks done

[Feature Request] Authority Validation enhacements #3775

bgavrilMS opened this issue Oct 31, 2022 · 1 comment · Fixed by #3818
Assignees
Milestone

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Oct 31, 2022

This is a consistency item.

Spec is here: https://microsoft.sharepoint.com/:w:/t/ADAL/ESzbQvzlMuBDjAsqfaHdjNUBsTmwIUR5g17IAY4rvOY_Hw?e=7dv5hZ

Tasks

  • Implement phase 2 WithInstanceDiscoevryEndpoint("DISABLED") which turns off all instance discovery
  • Ensure ESTS-R scenarios work in conjunction with this setting
  • Testing

@rayluo to confirm that only phase 2 is required and if phase1 ("WithKnownAuthorityHosts") is optional / recommended etc.

@rayluo
Copy link
Contributor

rayluo commented Oct 31, 2022

@rayluo to confirm that only phase 2 is required and if phase1 ("WithKnownAuthorityHosts") is optional / recommended etc.

Yes. Also, that internal specs grew along with the lengthy conversation. If you just want to focus on what ended up happening, this implementation PR in MSAL Python shipped only a boolean instance_discovery=True or False. You can for example take a look into its unit test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment