Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Update/ add to data logged to ITelemetryClient #3784

Closed
neha-bhargava opened this issue Nov 2, 2022 · 1 comment · Fixed by #3737
Closed

[Feature Request] Update/ add to data logged to ITelemetryClient #3784

neha-bhargava opened this issue Nov 2, 2022 · 1 comment · Fixed by #3737
Assignees

Comments

@neha-bhargava
Copy link
Contributor

neha-bhargava commented Nov 2, 2022

As discussed with E&D team following changed to be made to the telemetry client logging:

  • Api id to identify the type of request for example OBO/ Client credential

  • Type of confidential client for example if it is SNI based auth/ Certificate/ Assertion/ Managed Identity.

  • Log data for each resource in the scopes list.

  • Error codes: STS error code or MsalException error code (for client errors) or Exception type in the ErrorCode field.

  • Log token type as an enum instead of pop token.

  • Log the endpoint

  • Log the type of cache used. L1/ L2. This data can be stored in the TokenSource field. To make this change we need to expose a variable in TokenCacheNotificationArgs and pass this data back from Microsoft.Identity.Web.

  • In case of L2 cache failure (not cache miss, but for example timeout etc.), we want this logged as well. Perhaps a special TokenSource? (consider tracking separately)

The details are listed in this document.

@trwalke trwalke self-assigned this Dec 14, 2022
@trwalke trwalke removed their assignment Jan 10, 2023
@trwalke trwalke self-assigned this Feb 28, 2023
@bgavrilMS
Copy link
Member

2 small updates / clarifications:

  • we'd like to log separately - resource and scope (please only do string parsing if telemetry client is used)
  • for errors, we'd like to log separately the error string and the error code

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants