Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Remove unnecessary x-client info #4167

Closed
bgavrilMS opened this issue Jun 5, 2023 · 1 comment · Fixed by #4337
Closed

[Feature Request] Remove unnecessary x-client info #4167

bgavrilMS opened this issue Jun 5, 2023 · 1 comment · Fixed by #4337
Assignees
@trwalke
Labels
Feature Request
Milestone
4.57.0

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Jun 5, 2023 •
edited

Currently MSAL sends the following:

Name Example Value Notes
x-client-sku msal-netcore Identifies MSAL library (e.g. MSAL.NET on NET fwk, MSAL ObjC etc.)
x-client-version 4.45.0
x-client-CPU x64
x-client-OS Win Server 2016 Datacenter RuntimeInformation.OSDescription
x-client-DM Apple Iphone 14 Only on mobile and UWP

Understand if the service uses all this information. We should cut as much as possible irrelevant information. Even if it is low-impact from a privacy perspective, it is not 0-impact.

Proposal: cut the following

  • x-client-CPU
@bgavrilMS bgavrilMS added this to the 4.55.0 milestone Jun 5, 2023
@trwalke trwalke self-assigned this Sep 7, 2023
@trwalke trwalke mentioned this issue Sep 7, 2023
Merged
1 task
@trwalke trwalke linked a pull request Sep 7, 2023 that will close this issue
Disabling x-client-CPU #4337
Merged
1 task
@rayluo
Copy link
Contributor

rayluo commented Sep 26, 2023

Currently MSAL sends the following:

Name Example Value Notes
...

Proposal: cut the following

  • x-client-CPU

This proposal is also applicable to other MSALs, isn't it?

@rayluo rayluo mentioned this issue Oct 11, 2023
Merged
@bgavrilMS bgavrilMS mentioned this issue Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trwalke trwalke

Labels
Feature Request
Projects
MSAL.NET Customer Trust
Archived in project
Milestone
4.57.0
Development

Successfully merging a pull request may close this issue.

Disabling x-client-CPU AzureAD/microsoft-authentication-library-for-dotnet
3 participants
@rayluo @bgavrilMS @trwalke