Upgrading from MSAL-angular 0.x.x to 1.1.2 on the way to 2.x.x, acquireTokenSilent #3937
Unanswered
ingar-hillestad-4ss
asked this question in
Help
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We are trying to upgrade our Angular cli version, and on the way there we are upgrading the MSAL-angular library from version 0 thru 1.1.2 (msal 1.4.4) and eventually to 2.x.x.
But as far as I can see there is a major issue with that, starting in acquireTokenSilent(AuthenticationParameters), and how that has changed.
We are using Azure AD with federation, and because of that, we need to provide domain_hint in the url togheter with the login_hint. If not, we are just ending up with the well-known error relating to x-frame-options header not set, and getting the response times out.
After some digging in the library-code, I found that even though domain_hint is supplied in extraQueryParameters in the request, the call to ServerRequestParameters.generateQueryParametersString() explicit remove/ignores it. Those lines of code break the needed functionality. From what I can see, that code is the same in the newest version, so I can't just ignore it for now.
Are there any solutions to this that I can't see?
Segment of working url:
https://login.microsoftonline.com/te/xxxxxxxxx&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.4.4&login_hint=xx@domain&domain_hint=domain&client-request-id
Same segment of non-working url:
https://login.microsoftonline.com/te/xxxxxxxxx&client_info=1&x-client-SKU=MSAL.JS&x-client-Ver=1.4.4&login_hint=xx@domain&client-request-id
Beta Was this translation helpful? Give feedback.
All reactions