Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The uuid dependency is not an es6 module and does not work in the browser #874

Closed
1 of 5 tasks
nmetulev opened this issue Jul 26, 2019 · 0 comments · Fixed by #878
Closed
1 of 5 tasks

The uuid dependency is not an es6 module and does not work in the browser #874

nmetulev opened this issue Jul 26, 2019 · 0 comments · Fixed by #878
Assignees
Labels
compatibility Related to compatibility with specific frameworks, environments, browsers, etc.
Milestone

Comments

@nmetulev
Copy link

I'm submitting a...


[x] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

  • Chrome version XX
  • Firefox version XX
  • IE version XX
  • Edge dev latest
  • Safari version XX

Library version


Library version: 1.1.1

Current behavior

Using the es modules directly in a browser throws an error trying to load the uuid dependency. The uuid dependency does not support es modules but there is an open PR on their repo to add the support: uuidjs/uuid#317

Expected behavior

All dependencies can be loaded by the browser

Minimal reproduction of the problem with instructions

See https://github.com/nmetulev/msal-uuid for minimal repro

  • npm install
  • npm start

Open browser to localhost:3333 and open dev tools to see error in console

@jasonnutter jasonnutter added the compatibility Related to compatibility with specific frameworks, environments, browsers, etc. label Jul 29, 2019
@jasonnutter jasonnutter self-assigned this Jul 29, 2019
@jasonnutter jasonnutter added this to the 1.2.0 milestone Jul 29, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compatibility Related to compatibility with specific frameworks, environments, browsers, etc.
Projects
None yet
2 participants