Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAL is not safe for use in application extensions #1418

Closed
artemisia-absynthium opened this issue Dec 3, 2021 · 4 comments
Closed

MSAL is not safe for use in application extensions #1418

artemisia-absynthium opened this issue Dec 3, 2021 · 4 comments
Assignees
Labels

Comments

@artemisia-absynthium
Copy link

Hello,

I'm using MSAL in an app which has also a Widget extension where I need to make authenticated calls to refresh data, and since I started using MSAL from inside the widget I'm getting this warning:

linking against a dylib which is not safe for use in application extensions: /.../MSAL.framework/MSAL

So far nothing wrong has happened in this widget but I'm concerned that with time and/or changes, either in my app or in future MSAL updates, something wrong may start to happen since compatibility is not guaranteed in the first place.

Could it be possible to make the lib safe or, alternatively, release a separate module that's safe for application extensions?

Thank you very much!

@hieunguyenmsft
Copy link
Contributor

Other apps that use MSAL in their extension doesn't see the warning. Can you follow suggestion in this link to see if it helps:
https://stackoverflow.com/questions/28652102/how-to-suppress-warning-linking-against-dylib-not-safe-for-use-in-application

@artemisia-absynthium
Copy link
Author

Hi @hieunguyenmsft , thanks for pointing that out, I get the point now, anyway I don't feel comfortable in suppressing warnings so I will keep it.
Maybe you could file a feedback report to Apple though, for presenting the warning even if the unsafe code is properly isolated.
As for this issue, if I got it right and it's just a false positive, you can close it.
Thanks!

@hieunguyenmsft
Copy link
Contributor

Issue resolved. Thanks for reporting.

@3a4oT
Copy link

3a4oT commented Jul 12, 2023

I faced with same issue MSAL 1.2.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants