Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IHttpClientFactory to create the GraphServiceClient #780

Closed
1 of 8 tasks
damienbod opened this issue Nov 22, 2020 · 2 comments
Closed
1 of 8 tasks

Use IHttpClientFactory to create the GraphServiceClient #780

damienbod opened this issue Nov 22, 2020 · 2 comments
Assignees
@damienbod
Labels
enhancement New feature or request Performance
Projects
1.4.1
Milestone
1.4.1

Comments

@damienbod
Copy link

Which version of Microsoft Identity Web are you using?
Note that to get help, you need to run the latest version.
1.3.0

Where is the issue?

  • Web app
    • Sign-in users
    • Sign-in users and call web APIs
  • Web API
    • Protected web APIs (validating tokens)
    • Protected web APIs (validating scopes)
    • Protected web APIs call downstream web APIs
  • Token cache serialization
    • In-memory caches
    • Session caches
    • Distributed caches
  • Other (please describe)

performance improvement
@damienbod damienbod mentioned this issue Nov 22, 2020
Closed
@jmprieur jmprieur added this to To do in 1.4.0 via automation Nov 23, 2020
@jmprieur jmprieur added this to the 1.4.0 milestone Nov 23, 2020
@jmprieur jmprieur moved this from To do to In progress in 1.4.0 Nov 23, 2020
@jmprieur jmprieur added enhancement New feature or request Performance labels Nov 23, 2020
@jennyf19 jennyf19 added this to To do in 1.4.1 via automation Dec 3, 2020
@jennyf19 jennyf19 removed this from In progress in 1.4.0 Dec 3, 2020
@jennyf19 jennyf19 modified the milestones: 1.4.0, 1.4.1 Dec 3, 2020
@jennyf19 jennyf19 moved this from To do to Blocked/External waiting for reply in 1.4.1 Dec 3, 2020
@jmprieur
Copy link
Collaborator

jmprieur commented Dec 6, 2020

@damienbod : closing this issue as the PR is closed.
Feel free to reopen if you have a better idea.

1.4.1 automation moved this from Blocked/External waiting for reply to Done Dec 6, 2020
@tjkb
Copy link

tjkb commented Jun 4, 2024

@damienbod @jmprieur Is this issue still fixed? When I'm looking into Microsoft.Identity.Web.GraphServiceCollectionExtensions.AddMicrosoftGraph of version 2.19.0 then I don't see anymore that IHttpClientFactory is being used. Was it removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienbod damienbod

Labels
enhancement New feature or request Performance
Projects
No open projects
1.4.1
Done
Milestone
1.4.1
Development

Successfully merging a pull request may close this issue.

Use IHttpClientFactory to create the GraphServiceClient damienbod/microsoft-identity-web
4 participants
@damienbod @jmprieur @jennyf19 @tjkb