-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all URL parameters work in iframe embed player #14
Comments
Playing with the embed options in the Cloudflare Stream console, it would seem to confirm what you've found, and also for Default when no options specified:
|
I didn't include I meant to raise a separate issue of how to handle it. The Stream documentation seems to suggest that it wants the HTML enumerated options, so maybe we should add a line to map |
Fix implemented in 1cb2038. |
These seem to be broken again for me. At first glance from inspecting the page source and the iframe URL, I'm wondering if it has something to do with encoded ampersands...? |
Hopefully fixed now in 8b0b131. I've reverted to the use of The available advice was to percentage encode ampersands to |
It appears that the iframe player treats boolean parameters that are
false
by default as "true" if they are present at all in the querystring (even if they are set tofalse
).Affected parameters I've identified are
muted
,loop
, andautoplay
. (The behavior is documented for autoplay.)For example, the following iframe src results in a video that does autoplay, start muted, and loop. (But does not show controls.)
https://iframe.cloudflarestream.com/uid123456?muted=false&preload=false&loop=false&autoplay=false&controls=false
I found this updating the block, but it affects shortcodes as well. For example, the following shortcode generates a URL like the one above which treats autoplay, loop, and muted as effectively true.
I've raised the issue of at least documenting the behavior, if not allowing false values.
I think the best solution is to add some logic to where querystring parameters are added in Cloudflare_Stream_API::get_video_embed to simply not add parameters that are falsy or
"false"
.I'm working on a PR now.
The text was updated successfully, but these errors were encountered: