Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New option prefix for match-document-filename rule #1141

Merged
merged 2 commits into from
Dec 20, 2022
Merged

New option prefix for match-document-filename rule #1141

merged 2 commits into from
Dec 20, 2022

Conversation

TuvalSimha
Copy link
Collaborator

@TuvalSimha TuvalSimha commented Aug 18, 2022 •
edited by dotansimha

Related #1139

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2022 •
edited

🦋 Changeset detected

Latest commit: c358f11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-eslint/eslint-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dotansimha
dotansimha reviewed Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@dotansimha dotansimha left a comment •
edited by TuvalSimha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add changeset
  • add missing tests
  • make sure CI passes
  • test in another project (alpha release)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022 •
edited by theguild-bot

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-eslint/eslint-plugin 3.14.0-alpha-20221220171818-aa4bda7 npm ↗︎ unpkg ↗︎

dotansimha
dotansimha requested changes Aug 21, 2022
View reviewed changes
.changeset/light-lizards-know.md Outdated Show resolved Hide resolved
@dotansimha dotansimha linked an issue Sep 29, 2022 that may be closed by this pull request
new option prefix for match-document-filename rule #1139
Closed
dimaMachina
dimaMachina reviewed Dec 20, 2022
View reviewed changes
packages/plugin/src/rules/match-document-filename.ts Outdated
@@ -220,12 +249,13 @@ const rule: GraphQLESLintRule<[MatchDocumentFilenameRuleConfig]> = {
option = { style: option } as PropertySchema;
}
const expectedExtension = options.fileExtension || fileExtension;
let expectedFilename: string;
let expectedFilename = option.prefix || '';

if (option.style) {
expectedFilename =
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expectedFilename =
expectedFilename +=

@TuvalSimha you missed concatenation here, otherwise, if style is matchDocumentStyle prefix will be not applied

TuvalSimha and others added 2 commits December 20, 2022 18:10
@TuvalSimha @dimaMachina
prefix
7c0349b 
add spec

valid

invalid

invalid

changeset

minor changeset

fix changeset
@dimaMachina
fix
c358f11
@dimaMachina dimaMachina merged commit b1f2730 into master Dec 20, 2022
@dimaMachina dimaMachina deleted the prefix branch December 20, 2022 17:21
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

@dimaMachina dimaMachina dimaMachina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new option prefix for match-document-filename rule
3 participants
@TuvalSimha @dotansimha @dimaMachina