New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protect keys from writing/deleting/manipulating #625
Conversation
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
==========================================
- Coverage 94.52% 94.49% -0.04%
==========================================
Files 93 93
Lines 5959 6011 +52
==========================================
+ Hits 5633 5680 +47
- Misses 326 331 +5
Continue to review full report at Codecov.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Does this "arguments differ" warning raised by codacy origin from pylint? I cannot figure out which tool they use. The argument has been renamed from the top-level typing interface named "__m" to "mapping" for better user-experience. I can also add an ignore for this. |
it looks like the pylint run but I am fine with this kind of error (or adding a simple ignore 👍 ) |
If you expand the error box, the second line is:
So as @CagtayFabry said, its pylint. Just add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks! 🚀
Co-authored-by: vhirtham <volker.hirthammer@gmail.com>
these "kernel died" errors during the notebook tests seem unrelated to the latest change. |
Seems so, just restart the actions and see what happens (the simplest way is updating the branch. You have to do it anyways) |
Now the number of hacks involved to get or set protected keys has been increased further (just for you @vhirtham :D) |
Changes
Protect some keys from reading/writing/deleting/manipulating them. There is a list of attributes in file.py, which are being passed to the protected key dictionary. The WeldxFile now derives from it.
We need to deprecate the
data
attribute, as it allowed raw access.Related Issues
Closes #557
Checks