Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite _find_get to handle bools and added defaults for freqfit #17

Closed
wants to merge 1 commit into from

Conversation

amaliestokholm
Copy link
Contributor

@amaliestokholm amaliestokholm commented Sep 13, 2022

When during frequency fitting I discovered that it was required of me to specify threepoint=False in the freqparams xml tag.
That makes no sense as (i) that is for ratio fitting and (ii) it should be False by default.

I then discovered that _find_get could not handle the default value of threeport=False. This is a rewrite of that function.

While I was at it, I added defaults for fcor (cubicBG14), correlations (False), and dnufrac (0.15).
When fitting frequencies, you can simply just specify

<freqparams>
    <freqpath value={path-to-frequencies}
</freqparams>

and add <freqs/> to fitparams and maybe set

<freqplots>
    <True/>
</freqplots>.

@jakobmoss jakobmoss changed the base branch from main to devel November 14, 2022 12:58
@jakobmoss
Copy link
Contributor

Merged by #18 .

@jakobmoss jakobmoss closed this Nov 14, 2022
@jakobmoss jakobmoss deleted the updatefreqs branch November 14, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants