Rewrite _find_get to handle bools and added defaults for freqfit #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When during frequency fitting I discovered that it was required of me to specify
threepoint=False
in the freqparams xml tag.That makes no sense as (i) that is for ratio fitting and (ii) it should be False by default.
I then discovered that
_find_get
could not handle the default value ofthreeport=False
. This is a rewrite of that function.While I was at it, I added defaults for
fcor
(cubicBG14),correlations
(False), anddnufrac
(0.15).When fitting frequencies, you can simply just specify
and add
<freqs/>
to fitparams and maybe set