Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvesting refacturing #13

Merged
merged 13 commits into from
Feb 15, 2018
Merged

Harvesting refacturing #13

merged 13 commits into from
Feb 15, 2018

Conversation

sandrarum
Copy link
Member

Added Todos, Comments. Removed Controlpanel Datagrid-View for Harvester. Moved old harvesting to harvesting_old.

@coveralls
Copy link

coveralls commented Feb 15, 2018

Pull Request Test Coverage Report for Build 144

  • 36 of 47 (76.6%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+2.1%) to 62.926%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pkan/dcatapde/harvesting/data_cleaner/interfaces.py 1 2 50.0%
src/pkan/dcatapde/browser/content_views/harvester.py 25 26 96.15%
src/pkan/dcatapde/harvesting/source_type/rdfttl.py 0 3 0.0%
src/pkan/dcatapde/api/harvester.py 10 16 62.5%
Files with Coverage Reduction New Missed Lines %
src/pkan/dcatapde/api/harvester.py 1 55.26%
src/pkan/dcatapde/vocabularies/dcat_field.py 1 57.14%
src/pkan/dcatapde/harvesting/field_adapter/interfaces.py 2 66.67%
src/pkan/dcatapde/config/views.py 5 58.33%
Totals Coverage Status
Change from base Build 132: 2.1%
Covered Lines: 2142
Relevant Lines: 3404

💛 - Coveralls

@sandrarum sandrarum merged commit 7df53e9 into master Feb 15, 2018
@thomasmassmann thomasmassmann deleted the harvesting_refacturing branch February 16, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants