Skip to content

Commit

Permalink
chore: 🤖 removed linter from qunit tests
Browse files Browse the repository at this point in the history
BREAKING CHANGE: 🧨 removed classNameBindings
  • Loading branch information
miguel.nunez.mozota authored and josex2r committed Jun 21, 2019
1 parent 8170188 commit 050e64c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ before_script:

script:
- commitlint-travis
- npm run lint:js
- npm run lint
- COVERAGE=true node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup

after_script:
Expand Down
2 changes: 1 addition & 1 deletion ember-cli-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');

module.exports = function(defaults) {
const app = new EmberAddon(defaults, {
// Add options here
hinting: false
});

/*
Expand Down
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,13 @@
"husky": {
"hooks": {
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
"pre-push": "npm run lint:js && npm run test"
"pre-push": "npm run lint && npm run test"
}
},
"scripts": {
"build": "ember build",
"check-coverage": "istanbul check-coverage coverage/coverage-final.json --statements 85 --functions 85 --branches 85 --lines 85",
"lint": "npm run lint:js && npm run lint:hbs",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint --max-warnings 0 ./*.js addon app config tests",
"posttest": "npm run report-coverage && npm run check-coverage",
Expand Down Expand Up @@ -89,7 +90,7 @@
"ember-qunit": "^4.4.0",
"ember-resolver": "^5.1.1",
"ember-sinon": "^4.0.0",
"ember-source": "~3.10.0",
"ember-source": "https://s3.amazonaws.com/builds.emberjs.com/release/shas/41f1657f68735f214efeaa96eac96e8e093b4981.tgz",
"ember-source-channel-url": "^2.0.1",
"ember-try": "^1.1.0",
"eslint-config-bbva": "^2.0.3",
Expand All @@ -112,4 +113,4 @@
"url": "https://github.com/BBVAEngineering/ember-modal-service/issues"
},
"homepage": "https://github.com/BBVAEngineering/ember-modal-service#readme"
}
}

0 comments on commit 050e64c

Please sign in to comment.