Skip to content

Commit

Permalink
refactor: remove isEditing() method
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the method will not work after implementing event interests.
The client will not send events to bbj unless there a
callback registerd for that event in bbj. a developer can implement this
method again easily by registering callbacks for editing events.
  • Loading branch information
hyyan committed Jul 4, 2019
1 parent d27d7f6 commit 7565668
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions BBjGridExWidget.bbj
Expand Up @@ -756,7 +756,6 @@ class public BBjGridExWidget extends BBjWidget implements BBjGridExWidgetColumns
field protected Boolean IsReady! = BBjAPI.FALSE
field protected BBjVector backlog! = new BBjVector()
field protected BBjString URL$
field protected BBjNumber Editing! = 0
field protected BBjNumber newW!
field protected BBjNumber newH!
rem /**
Expand Down Expand Up @@ -1303,30 +1302,26 @@ class public BBjGridExWidget extends BBjWidget implements BBjGridExWidgetColumns
#onCellEvent(detail$,#ON_GRID_CELL_DOUBLE_CLICK())
break
case "gw.cellEditingStarted"
#Editing! = 1
#onCellEvent(detail$,#ON_GRID_CELL_EDITING_STARTED())
break
case "gw.cellEditingStopped"
#Editing! = 0
#onCellEvent(detail$,#ON_GRID_CELL_EDITING_STOPPED())
break
case "gw.cellValueChanged"
#onCellEvent(detail$,#ON_GRID_CELL_VALUE_CHANGED())
break
case "gw.rowEditingStarted"
#Editing! = 1
#onRowEditing(detail$,#ON_GRID_ROW_EDITING_STARTED())
break
case "gw.rowEditingStopped"
#Editing! = 0
#onRowEditing(detail$,#ON_GRID_ROW_EDITING_STOPPED())
break
case "gw.stateChanged"
#handleStateChangedEvent(detail$,#ON_GRID_STATE_CHANGE())
break
case "gw.contextmenu"
#onContextmenuEvent(detail$)
break
break
swend
methodend
rem /**
Expand Down Expand Up @@ -2813,14 +2808,6 @@ class public BBjGridExWidget extends BBjWidget implements BBjGridExWidgetColumns
#executeScript("gw_setFunctionsReadOnly('" + #GRIDID$ + "'," + str(readonly!) +")")
methodend
rem /**
rem * <br><b><small>#API</small></b>
rem *
rem * @return BBjNumber One if ag grid is in the editing mode , 0 otherwise
rem */
method public BBjNumber isEditing()
return #Editing
methodend
rem /**
rem * Get the current selected row
rem *
rem * <br><b><small>#API</small></b>
Expand Down

0 comments on commit 7565668

Please sign in to comment.