Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement debounced selection api #113

Closed
wants to merge 5 commits into from
Closed

Conversation

hyyan
Copy link
Member

@hyyan hyyan commented Mar 14, 2019

Work in progress: Please do not merge

Motivation #69

@StephanWald
The PR re-implement the selection API to be more sophisticated and faster.
The selected rows are fetched now from the client directly in real time. previously BBj waited for row selection events from the client and managed this independently.

The PR deprecates several callbacks too, which IMHO we do not need them (please tell me if anything deprecated is being used in Prodin).

Changes:

  1. Simplified BBjGridExWidgetSelectRowEvent
    1. removed field public BBjVector ChangedRows!
    2. removed field public BBjVector NewSelectedRows!
    3. removed field public BBjVector NewDeselectedRows!
    4. removed method public BBjNumber getRowCount()
      5 remvoed method public BBjNumber getDeselectedRowCount()
    5. removed method public BBjVector getNewSelectedRows()
    6. removed method public BBjVector getNewDeselectedRows()
  2. Parse events in the client before sending to BBj
  3. Debounce selectionChanged & doubleClick events to avoid event loss in BBj Side
  4. getSelectedRows returns BBjVector of BBjGridExWidgetRow
  5. getSelectedRow returns BBjGridExWidgetRow for the last selected row in the grid

@hyyan hyyan requested a review from StephanWald March 14, 2019 20:57
@hyyan hyyan changed the title (feat) implement debounced selection api feat: implement debounced selection api Mar 19, 2019
@hyyan hyyan force-pushed the feature-betterSelectionAPI branch from 66bc187 to 1481ae8 Compare March 27, 2019 17:55
hyyan added a commit that referenced this pull request Mar 27, 2019
@hyyan hyyan closed this Mar 27, 2019
@hyyan hyyan deleted the feature-betterSelectionAPI branch March 27, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants