[BUG] Imporper thread and status handling in reverseshell_stager_server

[Mr3Jane]

Empire Version

• Empire 4.9.0-kali-0kali1

OS Information (Linux flavor, Python version)

• OS: Linux kali 6.0.0-kali6-amd64
• Python: Python 3.10.9

Describe the bug

Plugin reverseshell_stager_server drops its thread handler with each execute call:

Empire/empire/server/plugins/reverseshell_stager_server.plugin

Line 117 in 34565d4

self.reverseshell_proc = None

While fixing this, I noticed that it also doesn't check if another handler is running, kinda implying that it allows to have multiple handlers at a time, which is not the case: you lose control of your previous handler if you run a new one:

Empire/empire/server/plugins/reverseshell_stager_server.plugin

Line 168 in 34565d4

elif self.status == "start":

And overall, current code doesn't terminate as expected as there's no timeout on socket.accept() call and spawned handler thread will hang and KThread will not be able to terminate it as well.

To Reproduce

Steps to reproduce the behavior:

1. Start reverseshell_stager_server
2. Try to stop reverseshell_stager_server or get its status
3. It won't work

Expected behavior

I expect this plugin to handle exactly 1 thread and allow to start it and stop it at will without losing control over the handler.

Screenshots

I think no screenshots is fine in this case

Additional context

Is it a known bug or plugins are handled somewhere outside of this repo? I've came with a simplistic solution, should I submit a PR with a proposed fix?