Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey in offline mode mixes jars on extraction #38

Open
cfraenkel opened this issue Aug 11, 2020 · 1 comment
Open

Journey in offline mode mixes jars on extraction #38

cfraenkel opened this issue Aug 11, 2020 · 1 comment

Comments

@cfraenkel
Copy link

when running the 0.4.0 offline jar on windows 10 I get a mixed extraction folder that contains the macos jars instead of the windows jars. This in turn leads to a method not found exception from the startup call that does not exist in the older mac version https://github.com/CodeBrig/Journey/blob/master/src/main/java/com/codebrig/journey/JourneyLoader.java#L197-L200.

I suspect that the extraction routine in https://github.com/CodeBrig/Journey/blob/master/src/main/java/com/codebrig/journey/JourneyLoader.java#L138 filtering logic is at fault

@BFergerson
Copy link
Owner

I believe the 0.4.0-offline distribution to be flawed and I don't currently have the time to fix it. If anyone has a macOS and is able to fix the TravisCI build I could build a new distribution. Till then I would recommend following these instructions: #30 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants