Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch full episode list of mikan source #237

Merged
merged 3 commits into from
Sep 6, 2020

Conversation

shincurry
Copy link
Contributor

issue: #236

bgmi/website/mikan.py Outdated Show resolved Hide resolved
@trim21
Copy link
Member

trim21 commented Aug 19, 2020

pre-commit install启用一下git hook(

@trim21
Copy link
Member

trim21 commented Aug 19, 2020

感谢PR
能不能加个测试用例

@shincurry
Copy link
Contributor Author

shincurry commented Aug 26, 2020

嗯?怎么测试突然又跑过了

另外,加测试是单独测试 mikan source 是否能拉取完整的episode列表吗,需要一些详细说明

@trim21
Copy link
Member

trim21 commented Aug 26, 2020

因为我去ci上面点了rerun()

单独测试 mikan source 的

@trim21
Copy link
Member

trim21 commented Aug 31, 2020

写了一下测试,但是没过,似乎是没处理subtitle_list参数

def test_mikan_fetch_all_episode():
    """
    大欺诈师 极影字幕社

    https://mikanani.me/Home/Bangumi/2242
    """
    w = mikan.Mikanani()
    results = w.fetch_episode_of_bangumi("2242", ["33"])
    assert len(results) > 15, "should fetch more episode in expand button"

@shincurry
Copy link
Contributor Author

shincurry commented Sep 1, 2020

加了一下测试,之前测试没过是因为那个页面里没有 ID 为 33 的字幕组

字幕组 ID:
极影字幕社 34
LoliHouse 370
SweetSub 357
Dymy字幕组 2

本地测试都跑过了 test_info[dmhy] 好像是网络问题 FAILED 应该不要紧

另外说一句,如果有心情的话,写一下 Contributing 文档吧,不然要跑个开发环境,跑个测试,满眼抓瞎

@trim21
Copy link
Member

trim21 commented Sep 1, 2020

ci有点蛋疼,经常网络问题测试不过

谢谢提醒,我这就写()

@trim21 trim21 merged commit 70750e9 into BGmi:dev Sep 6, 2020
@trim21 trim21 mentioned this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants