-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch full episode list of mikan source #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trim21
reviewed
Aug 19, 2020
|
shincurry
force-pushed
the
fix/mikan-source
branch
from
August 19, 2020 15:20
87b960c
to
0cf2610
Compare
感谢PR |
嗯?怎么测试突然又跑过了 另外,加测试是单独测试 mikan source 是否能拉取完整的episode列表吗,需要一些详细说明 |
因为我去ci上面点了rerun() 单独测试 mikan source 的 |
写了一下测试,但是没过,似乎是没处理 def test_mikan_fetch_all_episode():
"""
大欺诈师 极影字幕社
https://mikanani.me/Home/Bangumi/2242
"""
w = mikan.Mikanani()
results = w.fetch_episode_of_bangumi("2242", ["33"])
assert len(results) > 15, "should fetch more episode in expand button" |
加了一下测试,之前测试没过是因为那个页面里没有 ID 为 33 的字幕组 字幕组 ID: 本地测试都跑过了 test_info[dmhy] 好像是网络问题 FAILED 应该不要紧 另外说一句,如果有心情的话,写一下 Contributing 文档吧,不然要跑个开发环境,跑个测试,满眼抓瞎 |
shincurry
force-pushed
the
fix/mikan-source
branch
from
September 1, 2020 14:20
2b6952c
to
1a63332
Compare
ci有点蛋疼,经常网络问题测试不过 谢谢提醒,我这就写() |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #236