Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #400 #417

Merged
merged 11 commits into from
Mar 26, 2023
Merged

fix: issue #400 #417

merged 11 commits into from
Mar 26, 2023

Conversation

kahosan
Copy link
Contributor

@kahosan kahosan commented Mar 25, 2023

No description provided.

trim21
trim21 requested changes Mar 25, 2023
View reviewed changes
bgmi/website/mikan.py Outdated Show resolved Hide resolved
@trim21
Copy link
Member

trim21 commented Mar 25, 2023

你这么写不太行吧 ... config 只有在进程启动的时候才会被加载，会导致没登录情况下第一次运行命令的时候每个请求都进行一次登录 check_login_status(MIKAN_COOKIE)

@trim21
Copy link
Member

trim21 commented Mar 25, 2023

未登录情况下右上角有个 登录 按钮。

直接检查的html，未登录情况和登录情况下的页面是不一样的。如果发现未登录又设置了蜜柑的用户名密码的话就登录一下并且重发请求。

@trim21
Copy link
Member

trim21 commented Mar 26, 2023

有点问题... 我的密码里有 %，然而 python 的 ConfigParser 不支持 escape string...

@kahosan
Copy link
Contributor Author

kahosan commented Mar 26, 2023

有点问题... 我的密码里有 %，然而 python 的 ConfigParser 不支持 escape string...

我下午试试修复

@trim21
Copy link
Member

trim21 commented Mar 26, 2023

有点问题... 我的密码里有 %，然而 python 的 ConfigParser 不支持 escape string...

我下午试试修复

我修把

@trim21
Copy link
Member

trim21 commented Mar 26, 2023

还需要检查一下登录密码错误的情况

@trim21 trim21 merged commit fd4e68d into BGmi:master Mar 26, 2023
@kahosan kahosan deleted the fix-mikan branch March 26, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trim21 trim21 trim21 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kahosan @trim21